[BUGFIX] Display external pages on all levels of the main menu

[linawolf]

Sphinx handels it also that way

[jaapio]

I will have to review this more in depth, but it looks like there are a number of breaking changes in this pr.

Will come back to this later

[linawolf]

All places that use now DocumentEntryNode|ExternalEntryNode before used DocumentEntryNode so it shouldn't really be breaking.

Also as the Transformers are final they should not have been extended so we do not need to worry there.

I introduced a new level of inheritence in Nodes, however now the DocumentEntryNode extends the EntryNode which extends the AbstractNode, before it extended the AbstractNode directly. This should also be not breaking.

There is a slight possibility that someone expects all children of DocumentEntryNode to be DocumentEntryNode. And now this only returns an EntryNode. We could instead of altering getChildren introduce a new method and let getChildren filter only for DocumentEntryNodes?

[jaapio]

To be fair, we just released 1.0.0. So I do not expect anyone to use this functionality in to much depth, and the breaking change is limited. But I would like to get some awareness around the things that have been changed.

Stretching the arguments of methods is ok, people using the methods directly will not be impacted as we still accept the same types as before. The changes in the compiler passes should also not really impact people.

Changing return types is a no go, as I explained in the review comments. I would like to be constructive in this and not to strict. But I also want to ensure that we are all strict on these type of changes.

[linawolf]

@jaapio I have some questions, see above

[phpdoc-bot]

💚 All backports created successfully

Status	Branch	Result
✅	1.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation and see the Github Action logs for details