[FEATURE] Support directive image with target #914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would it not make more sense rather than having a image with a link to wrap the image in a hyperlink when the target is defined? This would allow you to reuse such hyperlinknode, and apply it to other situations. And it would also allow compiler passes to remove the target more easily. |
|
The InlineLinkNodes only accept text as content |
jaapio
force-pushed
the
feature/image-target
branch
from
6c6c3e9
to
a3508e2
Compare
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation and see the Github Action logs for details |
phpdoc-bot
added a commit
that referenced
this pull request
Mar 9, 2024
[1.x] Merge pull request #914 from phpDocumentor/feature/image-target
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #911