Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text-to-speech management (fixes #197, #170) #202

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

digital-carver
Copy link

  • Redirects the STDERR output of where command used in User.has_command? check. We deal with the result inside the program anyway, so error messages like in Error: "which: no say in (...$path...)" #170 and Error: no say in #197 are unnecessary.

  • Checks that a known text-to-speech program is available before turning speech ON.

  • Checks for command availability before performing various voice-related actions. For eg., currently betty list your voices when run in a system without the say command gives the output:

Betty: Running say -v "?"
sh: say: command not found

whereas with these changes, betty list your voices returns:

Betty: I don't seem to have a voice at all (the program 'say' would help me get some).

  • Some minor cleanup of the speak() function

@digital-carver
Copy link
Author

The has_command? change also fixes things like #189, which is most likely an incidental error message due to the invocation of the where command.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant