Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some considerations about this WIP:
_bake
was written supposing thatIPie.calcTokensForAmount()
returns(_, uint256[] amounts)
whereamounts
contains the amount of_inputToken
to spend for each underlying assetIPie.joinPool(uint256)
receive the amount of_inputToken
from which thepie
is baked/minted?Now some considerations about the implementation and possible edits:
ICurveExchange.get_best_rate
requires a lot of gas). We should think about exposing a pure function as:getBestPools(address _inputToken, address[] _outputTokens)
that returns something likeaddress[] pools
, representing the best pools. This can be encoded (like inUniPieRecipe
) and passed in thedata
field tobake
.