Add psycopg3 support to runmailer_pg

[jsmits]

Changes proposed in this PR:

• Add psycopg3 support to runmailer_pg and gracefully exit on SIGINT

Tips for an ideal PR

• You have read our Code of Conduct: https://github.com/pinax/.github/blob/master/CODE_OF_CONDUCT.md
• You have read our Contributing info: https://github.com/pinax/.github/blob/master/CONTRIBUTING.md
• The PR is atomic
• Unit tests have been updated/added, if needed
• App version number has been updated in setup.py (Pinax uses SemVer)
• Change Log has been updated
• You have added your name to the AUTHORS file

[spookylukey]

Hi @jsmits thanks for the PR.

Could you give me some context and a high level description about what is going on here? Thanks!

[jsmits]

Hi @jsmits thanks for the PR.

Could you give me some context and a high level description about what is going on here? Thanks!

Sure, no problem. I tried to run the runmailer_pg command in my latest django project and it crashed because my project uses psycopg3. Runmailer_pg expects psycopg2 still. This PR makes it seamlessly run with both, so if you have psycopg3 installed, it will use that, and if you have pscyopg2 installed, it will use that, just like it did before. Probably other people will run into this as well when they start using django with psycopg3 and the current django-mailer’s runmailer_pg.

[spookylukey]

Can you explain why this isn't just case of changing imports? Specifically what is different in psycopg3 that requires changes? Thanks!

[jsmits]

Can you explain why this isn't just case of changing imports? Specifically what is different in psycopg3 that requires changes? Thanks!

Basically two things:

• connection.poll() is not there anymore in psycopg3; instead you can consume its connection.notifies() generator, which I did
• psycopg3 does the autocommit part differently, the way psycopg2 did it doesn’t work anymore for psycopg3, that’s why just changing an import doesn’t work for this

[spookylukey]

Great, thank you!

[spookylukey]

Released just now in 2.3.2

[jsmits]

Awesome, thanks a lot!