Release candidate/2024 07 #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Problem Need to update generated code for the upcoming 2024-07 API release. ## Solution This PR closely follows the approach used in the python and typescript repositories. - I create a new `codegen` directory to act as the home for everything codegen related. Inside this directory there are several things: - Git submodule of our apis repo - A `build-oas.sh` script which does everything to generate the code off the spec The script does the following: - Pulls in the latest from the apis repo - Builds the api repo to produce versioned spec files - Generates java code off the spec file. - Copies files into their respective places in `src/` Run the script like this, passing api version number as a positional argument: ```sh ./codegen/build-oas.sh 2024-07 ``` ## Non-generated changes The updated spec produced slightly different generated code than in the past. In order for the project to compile, I had to make some adjustments: - Options for metric type are now part of the `IndexModel` class instead of a standalone metric object, requiring a small refactor along the lines of `IndexMetric.COSINE.toString()` to `IndexModel.MetricEnum.COSINE.toString()` and similar for other metric types. - The name and organization of create index spec objects has changed. Now you use: - `IndexSpec` instead of `CreateInexRequestSpec`. - `PodSpec` instead of `CreateIndexRequestSpecPod` - `PodSpecMetadataConfig` instead of `CreateIndexRequestSpecPodMetadataConfig` ## Type of Change - [x] None of the above: Update generated core, adjust usage for new generated classes ## Test Plan Code builds and tests pass
## Problem Add support for deletion protection. ## Solution Generated code using the following commands: ``` git submodule init && git submodule update ./codegen/build-oas.sh 2024-07 ``` Next, as a part of this PR, I have: 1. Added deletionProtection enum as an argument to createPodsIndex() and createServerlessIndex() 2. Renamed configureIndex() to configurePodsIndex() and added deletionProtection enum as an argument. 3. Added configureServerlessIndex() that accepts deletionProtection enum only. ## Type of Change - [X] New feature (non-breaking change which adds functionality) ## Test Plan Added integration tests
jhamon
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add deletion protection and generate code based on latest open api spec.
Solution
Generated code based on 2024-07 open api spec which includes deletion protection support. Manually added deletion protection support to the control plane wrapper along with integration tests.
Type of Change
Test Plan
Added integration tests