Add rerank #159
Merged
Add rerank #159
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanshah18
commented
Oct 18, 2024
| @@ -487,7 +487,7 @@ UpdateResponse updateResponse = index.update("v1", values, "example-namespace"); | |||
|
|
|||
| # Collections | |||
|
|
|||
| Collections fall under data plane operations. | |||
| Collections fall under control plane operations. | |||
There was a problem hiding this comment.
Error from before.
rohanshah18
changed the base branch from
main
to
rshah/release-candidate/2024-10
rohanshah18
requested review from
jhamon,
aulorbe,
austin-denoble and
ssmith-pc
rohanshah18
merged commit 1e8925a
into
rshah/release-candidate/2024-10
8 of 9 checks passed
rohanshah18
added a commit
that referenced
this pull request
Oct 24, 2024
## Problem Add rerank. ## Solution 1. Added the following two methods for rerank: a. Method that accepts required parameters only and the optional parameters are set to default. More details on the api and its default parameters can be found [here](https://docs.pinecone.io/reference/api/2024-10/inference/rerank). ```java rerank(String model, String query, List<Map<String, String>> documents) ``` b. Method that accepts all parameters: ```java rerank(String model, String query, List<Map<String, String>> documents, List<String> rankFields, int topN, boolean returnDocuments, Map<String, Object> parameters) ``` 2. Added integration tests for both rerank methods. 3. Added an example in the README file. ## Type of Change - [ ] Bug fix (non-breaking change which fixes an issue) - [X] New feature (non-breaking change which adds functionality) - [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected) - [ ] This change requires a documentation update - [ ] Infrastructure change (CI configs, etc) - [ ] Non-code change (docs, etc) - [ ] None of the above: (explain here) ## Test Plan Added integration test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Add rerank.
Solution
a. Method that accepts required parameters only and the optional parameters are set to default. More details on the api and its default parameters can be found here.
b. Method that accepts all parameters:
Type of Change
Test Plan
Added integration test.