Expose future stub on Pinecone connection #32
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit exposes the future stub on Pinecone connection, allowing for non-blocking async calls
Problem
PineconeConnection does not currently expose a stub for making asynchronous calls to the service. Async calls are very common in high traffic services.
Solution
Exposed the generated
VectorServiceGrpc.VectorServiceFutureStub
onPineconeConnection
. This returnscom.google.common.util.concurrent.ListenableFuture<V>
for each call, which allows chaining of asynchronous operations.The PR also removes an unused public method,
setBlockingStub
; can add this back if client API compatibility dictates.Type of Change
Test Plan
Run
sanityAsyncFuture
test