Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up integration tests #36

Merged
merged 1 commit into from
Oct 6, 2023
Merged

Clean up integration tests #36

merged 1 commit into from
Oct 6, 2023

Conversation

rohanshah18
Copy link
Contributor

@rohanshah18 rohanshah18 commented Oct 6, 2023 •
edited
Loading

Problem

Github CI was failing for integration test step.

Solution

Cleaned up package paths and added some additional assertions.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Ran unit and integration tests locally. Also the integration tests ran successfully on github CI.

@rohanshah18 rohanshah18 marked this pull request as ready for review October 6, 2023 19:37
@rohanshah18 rohanshah18 merged commit be78899 into main Oct 6, 2023
6 checks passed
@rohanshah18 rohanshah18 deleted the rshah/fixIntegTest branch October 6, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhamon jhamon jhamon approved these changes

@austin-denoble austin-denoble Awaiting requested review from austin-denoble

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohanshah18 @jhamon