Add integration tests for future stub #44
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamon
approved these changes
Nov 7, 2023
| @@ -20,7 +20,7 @@ | |||
| public class ConfigureIndexTest { | |||
| private PineconeIndexOperationClient pinecone; | |||
| private String indexName; | |||
| private static final Logger logger = LoggerFactory.getLogger(PineconeClientLiveIntegTest.class); | |||
| private static final Logger logger = LoggerFactory.getLogger(SyncStubTest.class); | |||
There was a problem hiding this comment.
Should this be ConfigureIndexTest.class?
| } | ||
|
|
||
| @Test | ||
| public void sanity() throws Exception { |
There was a problem hiding this comment.
I think this test is doing way too much. When a test like this fails, it takes a lot of investigation to figure out what is actually breaking.
Some operations (e.g. create & describe/list, upsert & fetch, upsert & query) make sense to use and test together, but you could still break this down into many smaller test cases.
I would have test cases for:
- Create index (with minimal params) and describe index
- Create index (passing all optional params) and describe index
- Upsert and fetch
- Upsert hybrid and fetch
- Upsert and fetch by id
- Upsert and query by id
- Upsert and query with vector values
- with
includeMetadata - with
includeValues
- with
- Upsert hybrid and query
- Edge cases (missing params, invalid names, wrong vector dimension, etc)
There was a problem hiding this comment.
This is great, thank you for providing me with this list. It has been like this since I picked up and always thought it was okay haha.
| @@ -185,7 +187,7 @@ public void sanity() throws Exception { | |||
| conn.getBlockingStub().delete(deleteRequest); | |||
| fetchRequest = FetchRequest.newBuilder().addAllIds(ids).setNamespace(namespace).build(); | |||
| fetchResponse = conn.getBlockingStub().fetch(fetchRequest); | |||
| assert (fetchResponse.getVectorsCount() == ids.size() - 1); | |||
| assertEquals (fetchResponse.getVectorsCount(), ids.size() - 1); | |||
There was a problem hiding this comment.
Suggested change
| assertEquals (fetchResponse.getVectorsCount(), ids.size() - 1); | |
| assertEquals(fetchResponse.getVectorsCount(), ids.size() - 1); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The sdk currently lacks integration tests for future stub which is used for data plane operations.
Solution
Added integration test for all data plane operations for future stub. As a part of this change, I have organized the integration test folder better by moving and renaming files:
ConfigureIndexTest.java:src/integration/java/io/pinecone/integration/ConfigureIndexTest.java -> src/integration/java/io/pinecone/ControlPlane/ConfigureIndexTest.java
PineconeIndexOperationsClientIntegrationTest.javatoCreateAndDeleteIndexTest.javaand moved it from: src/integration/java/io/pinecone/PineconeIndexOperationsClientIntegrationTest.java -> src/integration/java/io/pinecone/ControlPlane/CreateAndDeleteIndexTest.javaPineconeClientLiveIntegTest.javatoSyncStubTest.javaand moved it from:src/integration/java/io/pinecone/PineconeClientLiveIntegTest.java ->
src/integration/java/io/pinecone/DataPlane/SyncStubTest.java
I have also updated some weird assert calls with the correct assert functionality in SyncStubTest.java so the only files to review are:
Type of Change
Test Plan
Ran integration tests.