Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration test for deleting vectors #48

Merged
merged 4 commits into from
Dec 6, 2023
Merged

Conversation

rohanshah18
Copy link
Contributor

Problem

The sdk currently lacks integration tests for deleting vectors.

Solution

Vectors can be deleted in multiple ways, so added an integration tests that covers all of the different possibilities.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: Integration tests

Test Plan

Ran integration tests

@rohanshah18 rohanshah18 marked this pull request as ready for review November 29, 2023 16:15
Copy link
Contributor

@austin-denoble austin-denoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me, thanks for continuing to get the integration tests off the ground!

Most of my questions and comments are around readability of tests and aren't necessarily blocking. We could probably bike shed how we mock things for quite a while.

@rohanshah18 rohanshah18 merged commit f952fad into main Dec 6, 2023
8 checks passed
@rohanshah18 rohanshah18 deleted the rshah/upsertanddelete branch December 6, 2023 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants