Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update changelogs, examples, and readme #52

Merged
merged 3 commits into from
Dec 18, 2023
Merged

Update changelogs, examples, and readme #52

merged 3 commits into from
Dec 18, 2023

Conversation

rohanshah18
Copy link
Contributor

Problem

Prepare for next java sdk release.

Solution

Updated changelogs, examples, and readme for 0.7.0 release.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

NA

@rohanshah18 rohanshah18 marked this pull request as ready for review December 18, 2023 19:07
rohanshah18
rohanshah18 commented Dec 18, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
austin-denoble
austin-denoble approved these changes Dec 18, 2023
View reviewed changes
Copy link
Contributor

@austin-denoble austin-denoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, nice work getting this all wrapped up.

A few comments and questions. Thanks for cleaning up some of the integration test files.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
examples/java-basic-mvn/src/main/java/pineconeexamples/MinimalUpsertAndQueryExample.java Show resolved Hide resolved
@rohanshah18 rohanshah18 merged commit 639bb34 into main Dec 18, 2023
8 checks passed
@rohanshah18 rohanshah18 deleted the rshah/improveReadMe branch December 18, 2023 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austin-denoble austin-denoble austin-denoble approved these changes

@jhamon jhamon Awaiting requested review from jhamon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohanshah18 @austin-denoble