Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update configure index test and clean up control plane client #63

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Update configure index test and clean up control plane client #63

merged 6 commits into from
Feb 7, 2024

Conversation

rohanshah18
Copy link
Contributor

@rohanshah18 rohanshah18 commented Feb 5, 2024 •
edited
Loading

Problem

Test for configure index were missing. Also the open api spec was updated.

Solution

Add tests for configure index and updated open api generated code.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

Test Plan

Ran integration tests.

@rohanshah18 rohanshah18 marked this pull request as ready for review February 5, 2024 20:26
austin-denoble
austin-denoble approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@austin-denoble austin-denoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank for continuing to clean things up and re-enabling the configure index tests. 👍

src/main/java/io/pinecone/PineconeControlPlaneClient.java Show resolved Hide resolved
src/main/java/io/pinecone/PineconeControlPlaneClient.java Outdated Show resolved Hide resolved
@rohanshah18 rohanshah18 merged commit 051b696 into main Feb 7, 2024
2 of 6 checks passed
@rohanshah18 rohanshah18 deleted the rshah/controlPlaneTests branch February 7, 2024 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austin-denoble austin-denoble austin-denoble approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rohanshah18 @austin-denoble