Add collections operations to PineconeControlPlaneClient and collections integration tests
#64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…integration tests for collections, make changes to throwing PineconeException, changes to IndexManager helper functions
austin-denoble
changed the title
PineconeControlPlaneClient + integration testsPineconeControlPlaneClient and collections integration tests
… to gradle integrationTest in CI to get some sort of output
…Ready, clean up helper functions and tests
… happy path to ease flake
rohanshah18
reviewed
Feb 13, 2024
| @@ -21,14 +25,14 @@ public static void assertWithRetry(AssertionRunnable assertionRunnable, int back | |||
| success = true; | |||
| } catch (AssertionError | ExecutionException | IOException e) { | |||
| retryCount++; | |||
| delay*=backOff; | |||
| Thread.sleep(delay); | |||
| Thread.sleep(delayCount); | |||
There was a problem hiding this comment.
Why do we need this change? The last delayCount won't be used right?
rohanshah18
reviewed
Feb 13, 2024
| @@ -155,10 +154,6 @@ public void sizeIncrease() throws InterruptedException { | |||
|
|
|||
| } catch (Exception exception) { | |||
| logger.error(exception.getLocalizedMessage()); | |||
| } finally { | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Describe the purpose of this change. What problem is being solved and why?
Solution
add collections functionality to PineconeControlPlaneClient, add new integration tests for collections, make changes to throwing PineconeException, changes to IndexManager helper functions
Type of Change
Test Plan
Describe specific steps for validating this change.