Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collections operations to PineconeControlPlaneClient and collections integration tests #64

Closed
wants to merge 23 commits into from

Conversation

austin-denoble
Copy link
Contributor

Problem

Describe the purpose of this change. What problem is being solved and why?

Solution

add collections functionality to PineconeControlPlaneClient, add new integration tests for collections, make changes to throwing PineconeException, changes to IndexManager helper functions

Type of Change

  • New feature (non-breaking change which adds functionality)

Test Plan

Describe specific steps for validating this change.

…integration tests for collections, make changes to throwing PineconeException, changes to IndexManager helper functions
@austin-denoble austin-denoble changed the title Add collections operations to PineconeControlPlaneClient + integration tests Add collections operations to PineconeControlPlaneClient and collections integration tests Feb 8, 2024
@@ -21,14 +25,14 @@ public static void assertWithRetry(AssertionRunnable assertionRunnable, int back
success = true;
} catch (AssertionError | ExecutionException | IOException e) {
retryCount++;
delay*=backOff;
Thread.sleep(delay);
Thread.sleep(delayCount);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this change? The last delayCount won't be used right?

@@ -155,10 +154,6 @@ public void sizeIncrease() throws InterruptedException {

} catch (Exception exception) {
logger.error(exception.getLocalizedMessage());
} finally {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why was this removed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants