Detect plugins for Index and IndexGRPC classes #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhamon
commented
Oct 22, 2024
Comment on lines
+28
to
+34
| from ..utils import ( | ||
| setup_openapi_client, | ||
| parse_non_empty_args, | ||
| build_plugin_setup_client, | ||
| validate_and_convert_errors, | ||
| ) | ||
| from .features.bulk_import import ImportFeatureMixin |
There was a problem hiding this comment.
Most of these import changes are just cosmetic
austin-denoble
approved these changes
Oct 22, 2024
| # try block just in case to make sure a bad plugin doesn't | ||
| # halt client initialization. | ||
| openapi_client_builder = build_plugin_setup_client( | ||
| config=self.config, |
There was a problem hiding this comment.
I think this needs to be self._config. Currently seeing this error when it attempts to apply plugins to Index:
ERROR pinecone.data.index:index.py:129 Error loading plugins in Index: 'Index' object has no attribute 'config'
…e python-plugin-interface expects that field on target
austin-denoble
force-pushed
the
jhamon/index-plugin-detection
branch
from
32a999b
to
90df955
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Plugins not detected for Index/IndexGRPC classes
Solution
PineconeandPineconeGRPCclasses.Type of Change
Test Plan
To really validate this will probably require making a dev build release and installing alongside some actual plugins.