Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Datadog CI integration #403

Merged
merged 4 commits into from
Oct 25, 2024
Merged

[Chore] Datadog CI integration #403

merged 4 commits into from
Oct 25, 2024

Conversation

jhamon
Copy link
Collaborator

@jhamon jhamon commented Oct 23, 2024

Problem

To continue driving performance improvements in the SDK and avoid major regressions, we need to track performance over time. First step in that is figuring out how to send data over to datadog with ddtrace so we can begin to have a historical overview of how perf is changing over time.

Thanks to @ssmith-pc for pointing me in the right direction on how to get started with this stuff.

Solution

  • Add ddtrace dev dependency
  • Adjust CI configurations to set env variables expected by ddtrace

Probably later I will need to:

  • Develop some benchmark tests specifically exercising the areas where performance is most critical.
  • Setup some dashboards on the datadog side where we can easily find and interpret the data

Not sure if this link will be visible to others, but here's where I see data flowing into datadog https://app.datadoghq.com/ci/test-runs?saved-view-id=3068550

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Infrastructure change (CI configs, etc)
  • Non-code change (docs, etc)
  • None of the above: (explain here)

@jhamon jhamon changed the title Datadog CI integration [Chore] Datadog CI integration Oct 24, 2024
@jhamon jhamon marked this pull request as ready for review October 24, 2024 18:12
Copy link
Contributor

@rohanshah18 rohanshah18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and I verified the population in datadog, LGTM!

Copy link
Contributor

@ssmith-pc ssmith-pc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Contributor

@austin-denoble austin-denoble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it, it'll be great to get some metrics boards together for our CI pieces.

@jhamon jhamon merged commit efc751d into main Oct 25, 2024
25 of 26 checks passed
@jhamon jhamon deleted the jhamon/ddtrace branch October 25, 2024 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants