Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update window function docs #17991

Merged
merged 4 commits into from
Jul 18, 2024
Merged

Update window function docs #17991

merged 4 commits into from
Jul 18, 2024

Conversation

hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Jul 16, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.3 (TiDB 8.3 versions)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Jul 16, 2024
@ti-chi-bot ti-chi-bot bot added contribution This PR is from a community contributor. missing-translation-status This PR does not have translation status info. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Jul 16, 2024
@hfxsd hfxsd requested a review from qiancai July 16, 2024 12:57
@hfxsd hfxsd added translation/from-docs This PR is translated from a PR in pingcap/docs. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. and removed missing-translation-status This PR does not have translation status info. labels Jul 16, 2024
Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

functions-and-operators/expressions-pushed-down.md Outdated Show resolved Hide resolved
functions-and-operators/window-functions.md Outdated Show resolved Hide resolved
functions-and-operators/window-functions.md Outdated Show resolved Hide resolved
functions-and-operators/window-functions.md Outdated Show resolved Hide resolved
functions-and-operators/window-functions.md Outdated Show resolved Hide resolved
functions-and-operators/window-functions.md Outdated Show resolved Hide resolved
functions-and-operators/window-functions.md Outdated Show resolved Hide resolved
functions-and-operators/window-functions.md Outdated Show resolved Hide resolved
functions-and-operators/window-functions.md Outdated Show resolved Hide resolved
functions-and-operators/window-functions.md Outdated Show resolved Hide resolved
Copy link

ti-chi-bot bot commented Jul 18, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-18 07:04:52.575661538 +0000 UTC m=+510314.566603009: ☑️ agreed by qiancai.

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 18, 2024
@hfxsd hfxsd added the lgtm label Jul 18, 2024
@hfxsd hfxsd removed the contribution This PR is from a community contributor. label Jul 18, 2024
@hfxsd
Copy link
Collaborator Author

hfxsd commented Jul 18, 2024

/retest

@hfxsd
Copy link
Collaborator Author

hfxsd commented Jul 18, 2024

/approve

Copy link

ti-chi-bot bot commented Jul 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jul 18, 2024
@ti-chi-bot ti-chi-bot bot merged commit 1b97e82 into pingcap:master Jul 18, 2024
6 of 7 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/docs-cn that referenced this pull request Jul 18, 2024
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.1: #18028.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.2: #18029.

ti-chi-bot bot pushed a commit that referenced this pull request Jul 18, 2024
ti-chi-bot bot pushed a commit that referenced this pull request Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.1 Should cherry pick this PR to release-8.1 branch. needs-cherry-pick-release-8.2 Should cherry pick this PR to release-8.2 branch. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/from-docs This PR is translated from a PR in pingcap/docs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants