dumpling: New terminology for MySQL

[dveeden]

What problem does this PR solve?

Issue Number: close #53082

Problem Summary:

What changed and how does it work?

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No need to test

  • I checked and no code files have been changed.

Side effects

• Performance regression: Consumes more CPU
• Performance regression: Consumes more Memory
• Breaking backward compatibility

Documentation

• Affects user behaviors
• Contains syntax changes
• Contains variable changes
• Contains experimental features
• Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

Dumpling now supports dumpling databases from MySQL 8.4 and newer

[tiprow]

Hi @dveeden. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[codecov]

Codecov Report

Attention: Patch coverage is 38.88889% with 22 lines in your changes missing coverage. Please review.

Project coverage is 56.1986%. Comparing base (b522e98) to head (a282838).
Report is 10 commits behind head on master.

Additional details and impacted files

@@                Coverage Diff                @@
##             master     #57188         +/-   ##
=================================================
- Coverage   73.0639%   56.1986%   -16.8653%     
=================================================
  Files          1659       1785        +126     
  Lines        458021     638209     +180188     
=================================================
+ Hits         334648     358665      +24017     
- Misses       102834     255262     +152428     
- Partials      20539      24282       +3743     

Flag	Coverage Δ
integration	36.9275% <ø> (?)
unit	72.3059% <38.8888%> (-0.0348%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
dumpling	52.7673% <38.8888%> (-0.1806%)	⬇️
parser	∅ <ø> (∅)
br	51.1585% <ø> (+5.4509%)	⬆️

[lance6716]

/hold

free to unhold

[lance6716]

Maybe CI is also needed to be changed

++(dumpling/tests/consistency/run.sh:29): run_sql 'show master status;'
ERROR 1064 (42000) at line 1: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'master status' at line 1

[dveeden]

Maybe CI is also needed to be changed

++(dumpling/tests/consistency/run.sh:29): run_sql 'show master status;'
ERROR 1064 (42000) at line 1: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'master status' at line 1

Yes indeed. Trying to fix this in 2343947 but I'm not very familiar with how this test setup works

[dveeden]

/ok-to-test

[lance6716]

/unhold

[dveeden]

/retest

[dveeden]

/retest

[GMHDBJD]

LGTM

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GMHDBJD, lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [GMHDBJD,lance6716]
• dumpling/OWNERS [GMHDBJD,lance6716]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ti-chi-bot]

[LGTM Timeline notifier]

Timeline:

• 2024-11-07 02:19:12.241412523 +0000 UTC m=+1093865.080568069: ☑️ agreed by lance6716.
• 2024-11-07 11:49:38.214790652 +0000 UTC m=+1128091.053946195: ☑️ agreed by GMHDBJD.