Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove examples/internal #241

Merged
merged 1 commit into from
Sep 11, 2024
Merged

Remove examples/internal #241

merged 1 commit into from
Sep 11, 2024

Conversation

Sean-Der
Copy link
Member

Users find it frustrating that example code doesn't work out of tree. This makes copying the examples out of the repo easier.

Relates to pion/webrtc#1981

Copy link

codecov bot commented Sep 10, 2024

Codecov Report

Attention: Patch coverage is 0% with 266 lines in your changes missing coverage. Please review.

Project coverage is 0.00%. Comparing base (96595fe) to head (b5b268a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
gstreamer-send-offer/main.go 0.00% 26 Missing ⚠️
c-data-channels/main.go 0.00% 24 Missing ⚠️
ffmpeg-send/main.go 0.00% 24 Missing ⚠️
gstreamer-receive/main.go 0.00% 24 Missing ⚠️
gstreamer-send/main.go 0.00% 24 Missing ⚠️
play-from-disk-h264/main.go 0.00% 24 Missing ⚠️
play-from-disk-mkv/main.go 0.00% 24 Missing ⚠️
rtmp-to-webrtc/main.go 0.00% 24 Missing ⚠️
save-to-webm/main.go 0.00% 24 Missing ⚠️
sip-to-webrtc/main.go 0.00% 24 Missing ⚠️
... and 1 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #241    +/-   ##
=======================================
  Coverage    0.00%   0.00%            
=======================================
  Files          27      25     -2     
  Lines        2072    2246   +174     
=======================================
- Misses       2072    2246   +174     
Flag Coverage Δ
go 0.00% <0.00%> (ø)
wasm 0.00% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der force-pushed the remove-internal branch 2 times, most recently from 691d54e to 87167a0 Compare September 11, 2024 02:29
Users find it frustrating that example code doesn't work out of tree.
This makes copying the examples out of the repo easier.

Relates to pion/webrtc#1981
@Sean-Der Sean-Der merged commit fad9431 into master Sep 11, 2024
14 of 15 checks passed
@Sean-Der Sean-Der deleted the remove-internal branch September 11, 2024 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant