Remove the "Unknown" constants #1929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pionbot
force-pushed
the
unknown-constant
branch
from
9b6a790
to
f4ec7b4
Compare
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
wdouglass
force-pushed
the
unknown-constant
branch
from
f4ec7b4
to
1d30c2b
Compare
pionbot
force-pushed
the
unknown-constant
branch
from
1d30c2b
to
08be4d5
Compare
wdouglass
force-pushed
the
unknown-constant
branch
from
08be4d5
to
66987c3
Compare
pionbot
force-pushed
the
unknown-constant
branch
from
66987c3
to
1074371
Compare
wdouglass
force-pushed
the
unknown-constant
branch
4 times, most recently
from
d3c0898
to
8f572e7
Compare
Sean-Der
force-pushed
the
unknown-constant
branch
from
8f572e7
to
75db665
Compare
Sean-Der
force-pushed
the
unknown-constant
branch
from
75db665
to
127387e
Compare
This commit replaces the Unknown constant with separate constants for each enumeration that uses it. Fixes #1293
Sean-Der
force-pushed
the
unknown-constant
branch
from
127387e
to
2c5d35d
Compare
Sean-Der
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This patchset removes the
Unknownconstant, which may cause bugs and collide in various places around the codebaseThis is a draft until we start working toward 4.0 -- also, it uses an older version of pion/ice which will need to be patched.
Reference issue
Fixes #1293