Generate answer to match group bundle in offer #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
|
As the v4.0 has not been released, created a v3 branch to hold the v3 fix development, will pick this to master too once it is merged. @Sean-Der |
Generate answer to match group bundle in offer
cnderrauber
force-pushed
the
bundle_match
branch
from
7c11368
to
789da25
Compare
Sean-Der
approved these changes
Sep 7, 2023
|
Thanks for starting a /v3 @cnderrauber ! |
boks1971
approved these changes
Sep 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User report negotiation failed in livekit/livekit#1850.
When the client sends offer to stop a transceiver (inactive), it removes the media section from group bundle, but pion still includes the media section in the answer, making negotiation failed by
Failed to set remote answer sdp: A BUNDLE group in answer contains a MID='3' that was not in the offered group.