fix race in datachannel handleOpen #2587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @sukunrt ! |
Codecov ReportPatch coverage is
📢 Thoughts on this report? Let us know!. |
Take copy of bufferedAmountLowThreshold and onBufferedAmountLow. This allows us to this later without holding the lock.
Sean-Der
force-pushed
the
fix-datachannel-race
branch
from
49d8208
to
131dc2e
Compare
|
@sukunrt I tagged |
|
Oh wow, this is awesome! Thanks for the release @Sean-Der |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The two variables used here are protected by the mutex
muthey should only be accessed when the lock is held.Reference issue
#2586