Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3: Add PeerConnection.GracefulClose #2854

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Conversation

edaniels
Copy link
Member

@edaniels edaniels commented Aug 6, 2024

Running tests

Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 75.92593% with 26 lines in your changes missing coverage. Please review.

Project coverage is 80.15%. Comparing base (b8d3a7b) to head (4715107).

Files Patch % Lines
datachannel.go 67.64% 7 Missing and 4 partials ⚠️
operations.go 83.33% 4 Missing and 1 partial ⚠️
icegatherer.go 60.00% 2 Missing and 2 partials ⚠️
icetransport.go 81.81% 1 Missing and 1 partial ⚠️
internal/mux/mux.go 0.00% 2 Missing ⚠️
peerconnection.go 90.47% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2854      +/-   ##
==========================================
- Coverage   80.26%   80.15%   -0.11%     
==========================================
  Files          78       78              
  Lines        7504     7599      +95     
==========================================
+ Hits         6023     6091      +68     
- Misses       1054     1072      +18     
- Partials      427      436       +9     
Flag Coverage Δ
go 80.15% <75.92%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edaniels edaniels merged commit 4e4a67d into pion:v3 Aug 6, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant