Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump sctp to v1.8.33 #2871

Closed
wants to merge 2 commits into from
Closed

Bump sctp to v1.8.33 #2871

wants to merge 2 commits into from

Conversation

edaniels
Copy link
Member

waiting for tests

github.com/pion/sdp/v3 v3.0.9
github.com/pion/srtp/v2 v2.0.20
github.com/pion/stun v0.6.1
github.com/pion/transport/v2 v2.2.10
github.com/sclevine/agouti v3.0.0+incompatible
github.com/stretchr/testify v1.9.0
golang.org/x/net v0.22.0
golang.org/x/net v0.27.0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this required a go mod tidy -go=1.16 && go mod tidy -go=1.17 which is nonsense to me

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.11%. Comparing base (a49914b) to head (78d6736).
Report is 5 commits behind head on v3.

Additional details and impacted files
@@            Coverage Diff             @@
##               v3    #2871      +/-   ##
==========================================
- Coverage   80.16%   80.11%   -0.06%     
==========================================
  Files          78       78              
  Lines        7614     7614              
==========================================
- Hits         6104     6100       -4     
- Misses       1074     1077       +3     
- Partials      436      437       +1     
Flag Coverage Δ
go 80.11% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edaniels edaniels changed the title Bump sctp to v1.8.22 Bump sctp to v1.8.23 Aug 15, 2024
@edaniels edaniels changed the title Bump sctp to v1.8.23 Bump sctp to v1.8.33 Aug 15, 2024
@Sean-Der
Copy link
Member

@edaniels want me to merge this?

@edaniels
Copy link
Member Author

This would break 1.19 if we did so I think we gotta figure that out first?

@Sean-Der
Copy link
Member

Sean-Der commented Oct 7, 2024

@edaniels I am going to release v4.0.0 this week! With that stabilizing I think it's ok to stop updating v3.

If you disagree I am happy to figure out something else we can do here!

@Sean-Der Sean-Der closed this Oct 7, 2024
@edaniels
Copy link
Member Author

edaniels commented Oct 7, 2024

aye aye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants