Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow media engine to register custom payloader on mimetype #2931

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

LeeTeng2001
Copy link
Contributor

Description

Allow media engine to register custom payloader depending on the mime type

Reference issue

Fixes #2928

@Sean-Der
Copy link
Member

Looks great @LeeTeng2001!

  • Can you put it on the MediaEngine. That way users can configure per PeerConnection (or globally) if they want
  • Would it be possible to assert that Payload actually gets called?

@LeeTeng2001
Copy link
Contributor Author

@Sean-Der just to clarify, should I put it in both MediaEngine and global scope so that we ca either register it through global scope and media engine scope?

@LeeTeng2001
Copy link
Contributor Author

hi, I've updated a pr with payload assert and MediaEngine custom payloader scope

Allow custom payloader depending on the mime type

Fixes pion#2928
Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.97%. Comparing base (8fbf821) to head (8d4c57c).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2931      +/-   ##
==========================================
- Coverage   78.99%   78.97%   -0.03%     
==========================================
  Files          89       89              
  Lines        8573     8579       +6     
==========================================
+ Hits         6772     6775       +3     
- Misses       1311     1313       +2     
- Partials      490      491       +1     
Flag Coverage Δ
go 80.51% <100.00%> (-0.03%) ⬇️
wasm 63.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Sean-Der Sean-Der merged commit 271ab55 into pion:master Oct 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Enable user to register custom codec implementation
2 participants