Add SetFireOnTrackBeforeFirstRTP #2933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2933 +/- ##
==========================================
+ Coverage 78.99% 79.00% +0.01%
==========================================
Files 89 89
Lines 8573 8578 +5
==========================================
+ Hits 6772 6777 +5
Misses 1311 1311
Partials 490 490
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
edaniels
force-pushed
the
alwaysfireontrack
branch
from
4e3bbe5
to
1c20edf
Compare
Sean-Der
requested changes
Oct 15, 2024
|
@edaniels Could we put it behind SettingEngine? |
Yeah let's do that. Making Codec/PayloadType blocking feels bad as well |
edaniels
force-pushed
the
alwaysfireontrack
branch
from
1c20edf
to
d497d5d
Compare
edaniels
changed the title
|
@Sean-Der how about this? |
|
@edaniels sorry that didn't happen in
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow getting OnTrack events before RTP packets are received (non-simulcast)