Add CodeTF failure state to Result #31
Conversation
codetf.schema.json
Outdated
| "failureState": { | ||
| "type": "object", | ||
| "properties": { | ||
| "failed": { |
There was a problem hiding this comment.
This required failed boolean introduces complexity (more opportunities for the data to be invalid) and it makes this a breaking instead of an additive change.
Instead of the boolean, can we let the existence of the failure object indicate a failure? That would make this an additive change and reduce the number of invalid states.
There was a problem hiding this comment.
I'm not sure I see how this is a breaking change since failureState itself remains optional but I do think the boolean is redundant.
There was a problem hiding this comment.
Oh I didn't catch that. I thought failureState and this boolean were required
There was a problem hiding this comment.
In either case, the presence/absence of failure seems cleaner.
codetf.schema.json
Outdated
| @@ -87,6 +87,34 @@ | |||
| "description": "Vendor-specific properties to help storytelling", | |||
| "additionalProperties": true | |||
| }, | |||
| "failureState": { | |||
There was a problem hiding this comment.
Consider simply "failure" instead of "failureState". I feel like almost everything here is "state".
drdavella
force-pushed
the
add-failure-state
branch
from
baa28ca
to
9f7843f
Compare
No description provided.