Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ Feat ] Cleanup and improves #73

Merged
merged 15 commits into from
Sep 23, 2024
Merged

[ Feat ] Cleanup and improves #73

merged 15 commits into from
Sep 23, 2024

Conversation

posaune0423
Copy link
Contributor

@posaune0423 posaune0423 commented Sep 17, 2024 •
edited
Loading

Changes

  • improve format config
  • modify wrong version in Scarb_deploy.toml
  • update script
  • dd overlay so that we can grant writer role for each actions to necessary models much faster and easier!
  • update world address n account address for slot env
  • update README
  • add vscode task so that we can easily setup katana and torii keeping data and latest version.

@posaune0423 posaune0423 added the enhancement New feature or request label Sep 17, 2024
@posaune0423 posaune0423 self-assigned this Sep 17, 2024
@posaune0423 posaune0423 marked this pull request as ready for review September 17, 2024 21:56
@posaune0423 posaune0423 changed the title [ Feat ] Minor changes [ Feat ] Cleanup and Orgnize codes Sep 23, 2024
@posaune0423 posaune0423 changed the title [ Feat ] Cleanup and Orgnize codes [ Feat ] Cleanup and improves Sep 23, 2024
@thiscaspar
Copy link
Member

Thanks for the PR, LGTM

Keep in mind that the World Address changes with every version of Dojo... so needs to be updated, even in the .vscode/tasks.json

@thiscaspar thiscaspar merged commit cddf99d into main Sep 23, 2024
2 checks passed
@thiscaspar thiscaspar deleted the feat/minor-changes branch September 23, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thiscaspar thiscaspar Awaiting requested review from thiscaspar

Assignees

@posaune0423 posaune0423

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@posaune0423 @thiscaspar