Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX Merge more children PIDs to parents (fixes #72, maybe affects #14) #75

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

allanlaal
Copy link

the algorithm was faulty and returned the command name too early for the old exe_only condition, which meant that it did not enjoy the merging up to parents that discriminate_by_pid had:

before:

    1.1 GiB +   1.9 MiB =   1.1 GiB	WebExtensions         
    5.2 GiB + 871.5 KiB =   5.2 GiB	Privileged Cont       
    6.6 GiB + 297.6 MiB =   6.9 GiB	firefox-esr (23)
    8.9 GiB +   1.1 GiB =  10.0 GiB	chrome (137)
   19.6 GiB + 321.8 MiB =  19.9 GiB	firefox (48)
   36.6 GiB +  13.1 MiB =  36.6 GiB	Isolated Web Co (30)  

after:

    6.6 GiB + 297.6 MiB =   6.9 GiB	firefox-esr (23)
    8.9 GiB +   1.0 GiB =  10.0 GiB	chrome (137)
   62.6 GiB + 338.8 MiB =  63.0 GiB	firefox (86)

@pixelb
Copy link
Owner

pixelb commented Oct 20, 2022

Looks good I think. Will check more later and merge.
thanks!

@pixelb
Copy link
Owner

pixelb commented Oct 21, 2022

I'm not sure about the generality of this.
Since it's now returning the exe rather than cmd, it's changing the following on my system:

- 23.1 MiB + 554.5 KiB =  23.6 MiB      firewalld
+ 23.1 MiB + 555.5 KiB =  23.6 MiB      python3.8 [updated]

Also if we're not restricting the parent grouping to the same exe,
then might processes be incorrectly grouped in some cases
(like being associated with systemd or other init processes)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants