Make worker more resilient to DOM API usage attempts #7425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7425 +/- ##
=======================================
Coverage 72.60% 72.61%
=======================================
Files 1212 1212
Lines 37846 37846
Branches 7099 7099
=======================================
+ Hits 27479 27481 +2
+ Misses 10367 10365 -2 ☔ View full report in Codecov by Sentry. |
fregante
commented
Jan 25, 2024
| // The picker uses `bootstrap-switch-button`, which does a `window` check on load and breaks | ||
| // the MV3 background worker. Lazy-loading it keeps the background worker from breaking. | ||
| const { userSelectElement } = await import( | ||
| /* webpackChunkName: "editorContentScript" */ "@/contentScript/pageEditor/elementPicker" |
There was a problem hiding this comment.
Reverting the change in #7381 and adding a more appropriate comment.
3 tasks
grahamlangford
approved these changes
Jan 25, 2024
|
No loom links were found in the first post. Please add one there if you'd like to it to appear on Slack. Do not edit this comment manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The MV3 extension is failing to load due to an unchecked DOM access by the bricks. The dev tools make it difficult to find the source of this error.
Checklist
src/tsconfig.strictNullChecks.json(if possible)Related