Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for ORCID integration #10127

Open
2 tasks
ewhanson opened this issue Jun 25, 2024 · 1 comment
Open
2 tasks

Add tests for ORCID integration #10127

ewhanson opened this issue Jun 25, 2024 · 1 comment
Assignees
@ewhanson @taslangraham
Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Milestone
3.5 Internal

Comments

@ewhanson
Copy link
Collaborator

ewhanson commented Jun 25, 2024 •
edited
Loading

The current ORCID functionality has minimal testing. Both integration and unit tests should be added.

  • Job integration tests
  • e2e cypress testing for as much functionality as possible

Open questions:

  • How to mock ORCID API endpoints/OAuth process?

See #9899 for job test references

PRs (🚧 in progress):
@ewhanson ewhanson added the Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day. label Jun 25, 2024
@ewhanson ewhanson added this to the 3.5 Internal milestone Jun 25, 2024
@ewhanson ewhanson self-assigned this Jun 25, 2024
@ewhanson ewhanson moved this from Backlog to Under Development in Metadata and Distribution Jun 25, 2024
ewhanson added a commit to ewhanson/pkp-lib that referenced this issue Jun 28, 2024
@ewhanson
pkp#10127 Add Guzzle client mocking and test mail swap functionality
ae9818b
ewhanson added a commit to ewhanson/ojs that referenced this issue Jul 5, 2024
@ewhanson
pkp/pkp-lib#10127 WIP add DepositOrcidSubmissionTest
7434473
ewhanson added a commit to ewhanson/pkp-lib that referenced this issue Jul 5, 2024
@ewhanson
pkp#10127 Add Guzzle client mocking and test mail swap functionality
aee64c7
ewhanson added a commit to ewhanson/pkp-lib that referenced this issue Jul 5, 2024
@ewhanson
pkp#10127 WIP
7d19e38
ewhanson added a commit to ewhanson/pkp-lib that referenced this issue Jul 5, 2024
@ewhanson
pkp#10127 WIP add DepositOrcidSubmissionTest
72904de
ewhanson added a commit to ewhanson/pkp-lib that referenced this issue Jul 24, 2024
@ewhanson
pkp#10127 WIP add DepositOrcidSubmissionTest
81650ef
ewhanson added a commit to ewhanson/pkp-lib that referenced this issue Jul 24, 2024
@ewhanson
pkp#10127 Add Guzzle client mocking and test mail swap functionality
9d00557
ewhanson added a commit to ewhanson/pkp-lib that referenced this issue Jul 24, 2024
@ewhanson
pkp#10127 WIP
c75a8af
ewhanson added a commit to ewhanson/pkp-lib that referenced this issue Jul 24, 2024
@ewhanson
pkp#10127 WIP add DepositOrcidSubmissionTest
66a7b5c
ewhanson added a commit to ewhanson/ojs that referenced this issue Jul 24, 2024
@ewhanson
pkp/pkp-lib#10127 WIP add DepositOrcidSubmissionTest
159bf11
@touhidurabir touhidurabir mentioned this issue Aug 30, 2024
Open
51 tasks
@taslangraham taslangraham self-assigned this Oct 2, 2024
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Oct 15, 2024
@taslangraham
pkp#10127 Add e2e tests for ORCID
54f8fc0
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Oct 16, 2024
@taslangraham
pkp#10127 Add e2e tests for ORCID
380d6e1
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Oct 16, 2024
@taslangraham
pkp#10127 Add e2e tests for ORCID
572baaf
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Oct 16, 2024
@taslangraham
pkp#10127 Add e2e tests for ORCID
a812083
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Oct 16, 2024
@taslangraham
pkp#10127 Add e2e tests for ORCID
e5fc14d
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Oct 16, 2024
@taslangraham
pkp#10127 Add e2e tests for ORCID
ab8c479
taslangraham added a commit to taslangraham/pkp-lib that referenced this issue Oct 16, 2024
@taslangraham
pkp#10127 Add e2e tests for ORCID
fe5edf4
@taslangraham taslangraham mentioned this issue Oct 16, 2024
Draft
@taslangraham
Copy link
Contributor

@ewhanson I opened draft PRs with some e2e tests. Please take a look when you can:
pr - https://github.com/pkp/pkp-lib/pull/10524/files
ojs [tests] - pkp/ojs#4472

@Tribunal33 Tribunal33 mentioned this issue Oct 30, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ewhanson ewhanson

@taslangraham taslangraham

Labels
Housekeeping:1:Todo Any dependency management or refactor that would be nice to have some day.
Projects
Metadata and Distribution
Status: Under Development
Milestone
3.5 Internal
Development

No branches or pull requests
2 participants
@ewhanson @taslangraham