pkp/pkp-lib#9937 rename Editorial Team into Editorial History and remove Editorial Team nav menu item

classes/components/forms/context/PKPMastheadForm.php

@@ -89,24 +89,18 @@ public function __construct($action, $locales, $context, $imageUploadUrl)
                 'value' => $context ? $context->getData('country') : null,
             ]))
             ->addGroup([
-                'id' => 'keyInfo',
-                'label' => __('manager.setup.keyInfo'),
-                'description' => __('manager.setup.keyInfo.description'),
+                'id' => 'editorialMasthead',
+                'label' => __('common.editorialMasthead'),
+                'description' => __('manager.setup.editorialMasthead.description'),
             ])
-            ->addField(new FieldRichTextarea('description', [
-                'label' => __('manager.setup.contextSummary'),
+            ->addField(new FieldRichTextarea('editorialHistory', [
+                'label' => __('common.editorialHistory'),
                 'isMultilingual' => true,
-                'groupId' => 'keyInfo',
-                'value' => $context->getData('description'),
-            ]))
-            ->addField(new FieldRichTextarea('editorialTeam', [
-                'label' => __('manager.setup.editorialTeam'),
-                'isMultilingual' => true,
-                'groupId' => 'keyInfo',
+                'groupId' => 'editorialMasthead',
                 'toolbar' => 'bold italic superscript subscript | link | blockquote bullist numlist | image | code',
                 'plugins' => 'paste,link,lists,image,code',
                 'uploadUrl' => $imageUploadUrl,
-                'value' => $context->getData('editorialTeam'),
+                'value' => $context->getData('editorialHistory'),
             ]))
             ->addGroup([
                 'id' => 'about',

classes/migration/upgrade/v3_5_0/I9937_EditorialTeamToEditorialHistory.php

@@ -0,0 +1,48 @@
+<?php
+
+/**
+ * @file classes/migration/upgrade/v3_5_0/I9937_EditorialTeamToEditorialHistory.php
+ *
+ * Copyright (c) 2024 Simon Fraser University
+ * Copyright (c) 2024 John Willinsky
+ * Distributed under the GNU GPL v3. For full terms see the file docs/COPYING.
+ *
+ * @class I9937_EditorialTeamToEditorialHistory
+ *
+ * @brief Migrate/rename editorialTeam to editorialHistory context setting and remove Editorial Team navigation menu item.
+ */
+
+namespace PKP\migration\upgrade\v3_5_0;
+
+use Illuminate\Support\Facades\DB;
+use PKP\install\DowngradeNotSupportedException;
+use PKP\migration\Migration;
+
+abstract class I9937_EditorialTeamToEditorialHistory extends Migration
+{
+    abstract protected function getContextSettingsTable(): string;
+
+    /**
+     * Run the migration.
+     */
+    public function up(): void
+    {
+        DB::table($this->getContextSettingsTable())
+            ->where('setting_name', '=', 'editorialTeam')
+            ->update(['setting_name' => 'editorialHistory']);
+
+        // Because of the foreign keys constrains it is enough to
+        // only remove the entries from the table navigation_menu_items.
+        DB::table('navigation_menu_items')
+            ->where('type', 'NMI_TYPE_EDITORIAL_TEAM')
+            ->delete();
+    }
+
+    /**
+     * Reverse the migration
+     */
+    public function down(): void
+    {
+        throw new DowngradeNotSupportedException();
+    }
+}

classes/navigationMenu/NavigationMenuItem.php

@@ -24,7 +24,6 @@ class NavigationMenuItem extends \PKP\core\DataObject
     public const NMI_TYPE_ABOUT = 'NMI_TYPE_ABOUT';
     public const NMI_TYPE_SUBMISSIONS = 'NMI_TYPE_SUBMISSIONS';
     public const NMI_TYPE_MASTHEAD = 'NMI_TYPE_MASTHEAD';
-    public const NMI_TYPE_EDITORIAL_TEAM = 'NMI_TYPE_EDITORIAL_TEAM';
     public const NMI_TYPE_CONTACT = 'NMI_TYPE_CONTACT';
     public const NMI_TYPE_ANNOUNCEMENTS = 'NMI_TYPE_ANNOUNCEMENTS';
     public const NMI_TYPE_CUSTOM = 'NMI_TYPE_CUSTOM';
@@ -313,7 +312,6 @@ class_alias('\PKP\navigationMenu\NavigationMenuItem', '\NavigationMenuItem');
         'NMI_TYPE_ABOUT',
         'NMI_TYPE_SUBMISSIONS',
         'NMI_TYPE_MASTHEAD',
-        'NMI_TYPE_EDITORIAL_TEAM',
         'NMI_TYPE_CONTACT',
         'NMI_TYPE_ANNOUNCEMENTS',
         'NMI_TYPE_CUSTOM',

classes/services/PKPNavigationMenuService.php

@@ -62,11 +62,6 @@ public function getMenuItemTypes()
                 'title' => __('common.editorialMasthead'),
                 'description' => __('manager.navigationMenus.editorialMasthead.description'),
             ],
-            NavigationMenuItem::NMI_TYPE_EDITORIAL_TEAM => [
-                'title' => __('about.editorialTeam'),
-                'description' => __('manager.navigationMenus.editorialTeam.description'),
-                'conditionalWarning' => __('manager.navigationMenus.editorialTeam.conditionalWarning'),
-            ],
             NavigationMenuItem::NMI_TYPE_SUBMISSIONS => [
                 'title' => __('about.submissions'),
                 'description' => __('manager.navigationMenus.submissions.description'),
@@ -181,9 +176,6 @@ public function getDisplayStatus(&$navigationMenuItem, &$navigationMenu)
                     || (!$context && $request->getSite()->getData('enableAnnouncements'))
                 );
                 break;
-            case NavigationMenuItem::NMI_TYPE_EDITORIAL_TEAM:
-                $navigationMenuItem->setIsDisplayed($context && $context->getLocalizedData('editorialTeam'));
-                break;
             case NavigationMenuItem::NMI_TYPE_CONTACT:
                 $navigationMenuItem->setIsDisplayed($context && ($context->getData('mailingAddress') || $context->getData('contactName')));
                 break;
@@ -266,16 +258,6 @@ public function getDisplayStatus(&$navigationMenuItem, &$navigationMenu)
                         null
                     ));
                     break;
-                case NavigationMenuItem::NMI_TYPE_EDITORIAL_TEAM:
-                    $navigationMenuItem->setUrl($dispatcher->url(
-                        $request,
-                        PKPApplication::ROUTE_PAGE,
-                        null,
-                        'about',
-                        'editorialTeam',
-                        null
-                    ));
-                    break;
                 case NavigationMenuItem::NMI_TYPE_CONTACT:
                     $navigationMenuItem->setUrl($dispatcher->url(
                         $request,

locale/ar/manager.po

@@ -2351,14 +2351,6 @@ msgstr ""
 "هذا الرابط سيظهر فقط لو أنك قمت بتعبئة محتوى عن المجلة ضمن الإعدادات > "
 "المجلة."
 
-msgid "manager.navigationMenus.editorialTeam.description"
-msgstr "إرتبط بصفحة تعرض محتوى دفة القيادة المذكور ضمن الإعدادات > المجلة."
-
-msgid "manager.navigationMenus.editorialTeam.conditionalWarning"
-msgstr ""
-"هذا الرابط سيظهر فقط لو أنك قمت بتعبئة محتوى عن فريق التحرير ضمن الإعدادات > "
-"المجلة."
-
 msgid "manager.navigationMenus.submissions.description"
 msgstr "إرتبط بصفحة تعرض تعليمات تقديم طلب النشر."
 

locale/az/manager.po

@@ -2977,16 +2977,6 @@ msgstr ""
 "Bu link sadəcə \"Tənzimlər>Jurnal\" altındakı Jurnal haqqında bölməsini "
 "doldurmusunuzsa göstərilir."
 
-msgid "manager.navigationMenus.editorialTeam.description"
-msgstr ""
-"\"Tənzimlər> Jurnal\" bölməsindəki İdarəçi Siyahısı məzmununu göstərən bir "
-"səhifəyə link verin."
-
-msgid "manager.navigationMenus.editorialTeam.conditionalWarning"
-msgstr ""
-"Bu link sadəcə \"Tənzimlər >Jurnal\" altındakı şəxslər və şuralar bölməsini "
-"dpldurmusunuzsa göstərilir."
-
 msgid "manager.navigationMenus.submissions.description"
 msgstr "Məqalə təlimatlarını göstərən səhifəyə link verin"
 

locale/be@cyrillic/manager.po

@@ -2058,12 +2058,6 @@ msgstr ""
 msgid "manager.navigationMenus.about.conditionalWarning"
 msgstr ""
 
-msgid "manager.navigationMenus.editorialTeam.description"
-msgstr ""
-
-msgid "manager.navigationMenus.editorialTeam.conditionalWarning"
-msgstr ""
-
 msgid "manager.navigationMenus.submissions.description"
 msgstr ""
 

locale/bg/manager.po

@@ -2500,16 +2500,6 @@ msgstr ""
 "Тази връзка ще се показва само ако сте попълнили секцията \"За списанието\" "
 "в Настройки > Списание."
 
-msgid "manager.navigationMenus.editorialTeam.description"
-msgstr ""
-"Връзка към страница, показваща съдържанието на главния банер в Настройки > "
-"Списание."
-
-msgid "manager.navigationMenus.editorialTeam.conditionalWarning"
-msgstr ""
-"Тази връзка ще се показва само ако сте попълнили секцията \"Редакционен екип"
-"\" в Настройки > Списание."
-
 msgid "manager.navigationMenus.submissions.description"
 msgstr "Връзка към страницата, показваща инструкции за подаване на материали."
 

locale/bs/manager.po

@@ -2117,12 +2117,6 @@ msgstr ""
 msgid "manager.navigationMenus.about.conditionalWarning"
 msgstr ""
 
-msgid "manager.navigationMenus.editorialTeam.description"
-msgstr ""
-
-msgid "manager.navigationMenus.editorialTeam.conditionalWarning"
-msgstr ""
-
 msgid "manager.navigationMenus.submissions.description"
 msgstr ""
 

locale/ca/manager.po

@@ -2381,16 +2381,6 @@ msgstr ""
 "Aquest enllaç només es mostrarà si heu completat la secció \"Quant a la "
 "revista\" que hi ha a Configuració > Revista."
 
-msgid "manager.navigationMenus.editorialTeam.description"
-msgstr ""
-"Enllaç a un pàgina que mostri el contingut de la capçalera a Configuració > "
-"Revista."
-
-msgid "manager.navigationMenus.editorialTeam.conditionalWarning"
-msgstr ""
-"Aquest enllaç només es mostrarà si heu completat la secció d'equip editorial "
-"que hi ha a Configuració > Revista."
-
 msgid "manager.navigationMenus.submissions.description"
 msgstr "Enllaç a la pàgina que mostra les instruccions de tramesa."
 

locale/ckb/manager.po

@@ -2108,12 +2108,6 @@ msgstr ""
 msgid "manager.navigationMenus.about.conditionalWarning"
 msgstr ""
 
-msgid "manager.navigationMenus.editorialTeam.description"
-msgstr ""
-
-msgid "manager.navigationMenus.editorialTeam.conditionalWarning"
-msgstr ""
-
 msgid "manager.navigationMenus.submissions.description"
 msgstr ""
 

locale/cs/manager.po

@@ -2399,14 +2399,6 @@ msgstr ""
 "Tento odkaz se zobrazí pouze v případě, že jste v sekci Nastavení> Časopis "
 "vyplnili sekci O časopisu."
 
-msgid "manager.navigationMenus.editorialTeam.description"
-msgstr "Odkaz na stránku, která zobrazí obsah hlavičky v Nastavení > Časopis."
-
-msgid "manager.navigationMenus.editorialTeam.conditionalWarning"
-msgstr ""
-"Tento odkaz se zobrazí pouze v případě, že jste vyplnili sekci Redakční tým "
-"v Nastavení > Časopis."
-
 msgid "manager.navigationMenus.submissions.description"
 msgstr "Odkaz na stránku popisující pokyny pro podávání příspěvků."
 

locale/da/manager.po

@@ -2462,16 +2462,6 @@ msgstr ""
 "Dette link vil kun blive vist, hvis du har udfyldt feltet 'Om tidsskriftet' "
 "under Indstillinger > Tidsskrift."
 
-msgid "manager.navigationMenus.editorialTeam.description"
-msgstr ""
-"Link til en side, der viser indholdet i feltet 'Kolofon' under Indstillinger "
-"> Tidsskrift."
-
-msgid "manager.navigationMenus.editorialTeam.conditionalWarning"
-msgstr ""
-"Dette link vil kun blive vist, hvis du har udfyldt feltet 'Redaktionsgruppe' "
-"under Indstillinger > Tidsskrift."
-
 msgid "manager.navigationMenus.submissions.description"
 msgstr "Link til siden, der viser indsendelsesanvisninger."
 

locale/de/manager.po

@@ -2504,16 +2504,6 @@ msgstr ""
 "Dieser Link wird nur angezeigt, falls Sie den Abschnitt Über uns in den "
 "Einstellungen > Zeitschrift ausgefüllt haben."
 
-msgid "manager.navigationMenus.editorialTeam.description"
-msgstr ""
-"Link zur Seite, welche den Inhalt des Impressums aus den Einstellungen > "
-"Zeitschrift anzeigt."
-
-msgid "manager.navigationMenus.editorialTeam.conditionalWarning"
-msgstr ""
-"Dieser Link wird nur angezeigt, falls Sie den Abschnitt Herausgeber-Team "
-"unter Einstellungen > Zeitschrift ausgefüllt haben."
-
 msgid "manager.navigationMenus.submissions.description"
 msgstr "Link zur den Einreichungsrichtlinien."
 

locale/el/manager.po

@@ -2365,16 +2365,6 @@ msgstr ""
 "Αυτός ο σύνδεσμος θα εμφανιστεί μόνο αν έχετε συμπληρώσει την ενότητα "
 "\"Σχετικά με το Περιοδικό\" στις Ρυθμίσεις > Περιοδικό."
 
-msgid "manager.navigationMenus.editorialTeam.description"
-msgstr ""
-"Σύνδεση σε μια σελίδα που εμφανίζει το περιεχόμενο του Κύριου Τίτλου στις "
-"Ρυθμίσεις > Περιοδικό."
-
-msgid "manager.navigationMenus.editorialTeam.conditionalWarning"
-msgstr ""
-"Αυτός ο σύνδεσμος θα εμφανιστεί μόνο αν έχετε συμπληρώσει την ενότητα "
-"\"Ομάδα Συντακτών\" στις Ρυθμίσεις > Περιοδικό."
-
 msgid "manager.navigationMenus.submissions.description"
 msgstr "Σύνδεση με τη σελίδα που εμφανίζει τις οδηγίες υποβολής."
 

locale/en/manager.po

@@ -1860,7 +1860,7 @@ msgstr "Yes, require submitting authors to upload one or more of these files."
 msgid "manager.setup.genres.submitRequired.no"
 msgstr "No, allow new submissions without these files."
 
-msgid "manager.setup.editorialMasthead.description"
+msgid "manager.setup.appereance.editorialMasthead.description"
 msgstr "Define the order of editorial masthead roles for public display."
 
 msgid "manager.settings.wizard"
@@ -2385,11 +2385,12 @@ msgstr "A URL must be provided"
 msgid "manager.navigationMenus.form.conditionalDisplay"
 msgstr "Learn more about when this menu item will be displayed or hidden."
 
+#, fuzzy
 msgid "manager.navigationMenus.form.submenuWarning"
 msgstr ""
 "When a menu item opens a submenu, it's link can not be followed on all "
 "devices. For example, if you have an \"About\" item which opens a submenu "
-"with \"Contact\" and \"Editorial Team\", the \"About\" link may not be "
+"with \"Contact\" and \"Editorial Masthead\", the \"About\" link may not be "
 "reachable on all devices. In the default menu, this is handled by creating a "
 "second menu item, \"About the Journal\", which appears in the submenu."
 
@@ -2421,14 +2422,6 @@ msgstr ""
 "This link will only be displayed if you have filled out the About the "
 "Journal section under Settings > Journal."
 
-msgid "manager.navigationMenus.editorialTeam.description"
-msgstr "Link to a page displaying the Masthead content in Settings > Journal."
-
-msgid "manager.navigationMenus.editorialTeam.conditionalWarning"
-msgstr ""
-"This link will only be displayed if you have filled out the Editorial Team "
-"section under Settings > Journal."
-
 msgid "manager.navigationMenus.editorialMasthead.description"
 msgstr "Link to a page displaying all active editorial masthead services."
 

locale/es/manager.po

@@ -2484,16 +2484,6 @@ msgstr ""
 "Este enlace solo se mostrará si ha completado la sección Acerca de esta "
 "revista bajo Ajustes > Revista."
 
-msgid "manager.navigationMenus.editorialTeam.description"
-msgstr ""
-"Enlace a una página que muestre el contenido de la cabecera en Ajustes > "
-"Revista."
-
-msgid "manager.navigationMenus.editorialTeam.conditionalWarning"
-msgstr ""
-"Este enlace solo se mostrará si ha completado la sección equipo editorial en "
-"Ajustes > Revista."
-
 msgid "manager.navigationMenus.submissions.description"
 msgstr "Enlace a la página que muestra las instrucciones de envío."
 

locale/eu/manager.po

@@ -2135,12 +2135,6 @@ msgstr ""
 msgid "manager.navigationMenus.about.conditionalWarning"
 msgstr ""
 
-msgid "manager.navigationMenus.editorialTeam.description"
-msgstr ""
-
-msgid "manager.navigationMenus.editorialTeam.conditionalWarning"
-msgstr ""
-
 msgid "manager.navigationMenus.submissions.description"
 msgstr ""
 

locale/fa/manager.po

@@ -2180,14 +2180,6 @@ msgstr ""
 "این لینک تنها در صورتی که بخش درباره مجله (در قسمت تنظیمات > مجله) تکمیل شده "
 "باشد، نمایش داده خواهد شد."
 
-msgid "manager.navigationMenus.editorialTeam.description"
-msgstr "لینک به صفحه نمایش اطلاعات کلی مجله"
-
-msgid "manager.navigationMenus.editorialTeam.conditionalWarning"
-msgstr ""
-"این لینک تنها در صورتی که بخش تیم سردبیر مجله (در قسمت تنظیمات > مجله) تکمیل "
-"شده باشد، نمایش داده خواهد شد."
-
 msgid "manager.navigationMenus.submissions.description"
 msgstr "لینک به صفحه دستورالعمل‌های ثبت مقاله"