Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add "Deny All" Dns Resolver #344

Merged
merged 1 commit into from
Oct 25, 2024
Merged

add "Deny All" Dns Resolver #344

merged 1 commit into from
Oct 25, 2024

Conversation

parkma99
Copy link
Contributor

implement #329

Copy link
Member

@GlenDC GlenDC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good.
Can you apply these changes,
and pull it onto your machine.

You might need to run just qa to quickly check if all passes.
It will also auto format in case there is some formatting to be done.

Should you not have just on your machine you probably can find install instructions
on https://just.systems/man/en/installation.html or for this instance you might get away to just check if cargo fmt --all doesn't give you new changes to commit.

If not too much to ask you can also squash your commits, but if not, also not ok, for now I'm still okay either way, it's what you want.

rama-dns/src/deny_all.rs Outdated Show resolved Hide resolved
rama-dns/src/deny_all.rs Outdated Show resolved Hide resolved
Co-authored-by: Glen De Cauwsemaecker <[email protected]>
@parkma99
Copy link
Contributor Author

Thanks, now all tests is passed, I find git is little confusing😊

@GlenDC
Copy link
Member

GlenDC commented Oct 25, 2024

Thanks, now all tests is passed, I find git is little confusing😊

Yeah it is not something that one can just use without learning the nuances sadly.
Should you be interested I find https://git-scm.com/book/en/v2 still the leading resource
that is worth reading at least once in your career. Certainly most chapters, but not all.

Thanks for this contribution by the way, greatly appreciated.
Going to give it a last review, if it's okay and also all CI checks pass, I'll merge it in.
Otherwise I'll come back with more feedback.

Feel free to pick up another one, give feedback in any other way, or just leave it as-is.
Either way, have a nice life ahead of you and I wish you all the best!

@GlenDC GlenDC merged commit e0b2f57 into plabayo:main Oct 25, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants