Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it work for 32 bits platform with _FILE_OFFSET_BITS=64 #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jief666
Copy link

@jief666 jief666 commented Jun 16, 2018

There was a arithmetic problem on 32 bits platform when off_t is 64 bits.
Basically, we have to make sure to convert to 64 bits BEFORE the multiplication. Hence things like : ((off_t)extent->startBlock) * blockSize.

@jief666
Copy link
Author

jief666 commented Jul 10, 2018

After this one, if you're still interested in that project, I can submit few pull requests.
I worked on :
removing memory leaks
removing warning
extended attributes
sparsebundle, clear or encrypted, support
adding fuse support
UTF8 encoding
As of today, mounting an image with libdmg is the exact same as mounting it on Mac. Test with huge images 300-400TB on Mac and on linux 32 bits.

@jief666 jief666 closed this Jul 10, 2018
@jief666 jief666 reopened this Jul 10, 2018
vasi pushed a commit to vasi/libdmg-hfsplus that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant