Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Forecast Temperature when using OpenWeatherMap #18

Open
wants to merge 8 commits into
base: master
Choose a base branch
from

Conversation

shawnline
Copy link

Prior to this code change, forecast temperatures using OpenWeatherMap failed to load correctly. It does now.

Prior to this code change, forecast temperatures using OpenWeatherMap failed to load correctly. It does now.
@plarus plarus linked an issue Dec 29, 2020 that may be closed by this pull request
@plarus
Copy link
Owner

plarus commented Dec 29, 2020

Hello Shawnjoseph2001

Thanks for this pull request.
I haven't used my pebble watch for a while.
So I don't work too much on this project anymore and I'm not sure to make a new version...

Pierre

@shawnline
Copy link
Author

shawnline commented Jan 30, 2021

Hello! Can I have your permission to update the version of this app on the Rebble store with this fixed version? One of the maintainers on the store has allowed me to do so as long as I get your permission. They can do it for you without any work from you. You can review my code changes if you want, very little is changed between the versions except for the forecast fix. Thank you!

Copy link

@KyLeggiero KyLeggiero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove .DS_Store from this PR 😁

@KyLeggiero
Copy link

Thanks, @Shawnjoseph2001! Just don't forget about Git's weirdness where it doesn't remove files ignored after they were committed; they still have to be manually removed.

@plarus
Copy link
Owner

plarus commented Jan 31, 2021

Hello @Shawnjoseph2001!

You will provide the app with your own openweathermap private key?
How do I give you this authorization?

@shawnline
Copy link
Author

shawnline commented Jan 31, 2021 via email

@plarus
Copy link
Owner

plarus commented Feb 1, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Weather Forecast Doesn’t Load
3 participants