-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Forecast Temperature when using OpenWeatherMap #18
base: master
Are you sure you want to change the base?
Conversation
Prior to this code change, forecast temperatures using OpenWeatherMap failed to load correctly. It does now.
Hello Shawnjoseph2001 Thanks for this pull request. Pierre |
Hello! Can I have your permission to update the version of this app on the Rebble store with this fixed version? One of the maintainers on the store has allowed me to do so as long as I get your permission. They can do it for you without any work from you. You can review my code changes if you want, very little is changed between the versions except for the forecast fix. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't forget to remove .DS_Store
from this PR 😁
Thanks, @Shawnjoseph2001! Just don't forget about Git's weirdness where it doesn't remove files ignored after they were committed; they still have to be manually removed. |
Hello @Shawnjoseph2001! You will provide the app with your own openweathermap private key? |
Yeah, I have my own OWM key. Just respond to this thread saying you’d be OK with it, and I’ll show it to the Rebble admins. https://prnt.sc/xxgwxl
Shawn
…--
/// || || /\ \\ /\ //|\ ||
\\\ |||||| //\\ \\ //\\ // |\\||
/// || || // \\ \// \\/ ||\\|
Shawn Joseph
On Jan 31, 2021, 4:09 AM -0800, plarus ***@***.***>, wrote:
Hello @Shawnjoseph2001!
You will provide the app with your own openweathermap private key?
How do I give you this authorization?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
Ok, I give you the permission to update the version of this app on the
Rebble store with this fixed version
Pierre
Le dim. 31 janv. 2021 à 18:47, Shawn Joseph <[email protected]> a
écrit :
… Yeah, I have my own OWM key. Just respond to this thread saying you’d be
OK with it, and I’ll show it to the Rebble admins. https://prnt.sc/xxgwxl
Shawn
--
/// || || /\ \\ /\ //|\ ||
\\\ |||||| //\\ \\ //\\ // |\\||
/// || || // \\ \// \\/ ||\\|
Shawn Joseph
On Jan 31, 2021, 4:09 AM -0800, plarus ***@***.***>, wrote:
> Hello @Shawnjoseph2001!
> You will provide the app with your own openweathermap private key?
> How do I give you this authorization?
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or unsubscribe.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#18 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AD5W24QLM6XUPFJJAVMAUBDS4WJUDANCNFSM4VHYYJFA>
.
|
This reverts commit 5ae503b.
Prior to this code change, forecast temperatures using OpenWeatherMap failed to load correctly. It does now.