New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JACOBIN-498 Make trace.ErrorMsg formatting like log.Log-severe #246

Merged

platypusguy merged 2 commits into platypusguy:main from texadactyl:main

Oct 26, 2024

Collaborator

texadactyl commented Oct 25, 2024 •

edited

Loading

modified: trace/trace.go

Two reasons:

Compatibility with previous severe messages
jacotest cannot tolerate time-stamps in severe error messages because it throws off comparison to the previous result (false differences)

texadactyl added 2 commits

October 25, 2024 16:30


          trace ErrorMsg should use no time stamp just like log SEVERE

fc139d2


          Merge branch 'main' of https://github.com/texadactyl/jacobin

bd2fdb1

texadactyl requested a review from platypusguy

October 25, 2024 21:37

Collaborator Author

texadactyl commented Oct 25, 2024

Now, jacotest no longer thinks that the last 2 results are different simply because the time-stamps are different.

platypusguy merged commit 858e82b into platypusguy:main

3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet