-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JACOBIN-610 Alleviate some of anomalies that jacotest case JACOBIN-0433-HexFormat is exposing #256
Conversation
At this point in JACOBIN-0433-HexFormat:
Implementing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure about this edit. We need to be able to handle Java bytes (i.e., int8) at every point in the process where bytes might be accessed. I update BALOAD earlier to work with arrays of int8.
@platypusguy |
JACOBIN-0433-HexFormat now passes. |
java/nio/charset/StandardCharsets.<clinit>()V
as atrapFunction
inotherModules.go
.HexFormat.<clinit>
. BALOAD and object.ArrayLength cannot handle slices of int8. I suspect other op codes are in the same boat. Also, these are not 1-byte signed integers.jdk/internal/util/ArraysSupport.<clinit>
needs a call toclinitGeneric
.