-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor view options #104
Editor view options #104
Conversation
I think these settings belong in the OPTIONS section of the UI panel. Can you move them there and update the screenshot in the PR description please? |
done. |
I think Mode belongs in the SELECTION section actually. The UI does need a bit of a redesign, I think. I'm meeting someone about it today. 😄 Sorry about the changes we've made since you submitted your PR - there are a couple of files with conflicts to resolve. |
no problem, ill adapt it further when you request it. |
If you could merge from the main branch into your fork, that'd be great! |
# Conflicts: # src/editor.ts # src/ui/control-panel.ts
done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making all the requested changes, @7Jaws9Eyes. So consider my review a first pass - we still need feedback and a review from @slimbuck. He's out this week but will be back on Monday.
boundary rings will keep color even if splat highlighting is toggled off accidentally introduced this bug when cleaning up keyboard shortcuts
This was eventually done in #258 |
Added a bunch of configurable viewing options to the side bar, including keyboard shortcuts for toggles.
Could be useful to make selecting splats more precise, especially if more editing tools are added in the future.
Sidebar with new options:
Center point colors and alpha value can be changed. Same for selected center points.
Keyboard shortcut J toggles center point alpha.
Keyboard shortcut L toggles alpha of selected center points.
(image below shows 2 custom colors and alpha values for center points)
Color of splats in selection can be interpolated with custom color. (interpolation 0 leaves color of selected splats unchanged).
K toggles selected splat coloration.
Bounding rings of splats can be enabled in the centers view mode -> centers and bounds in same view. Can also be only enabled for selected splats.
Keyboard shortcut O toggles bounding rings. Q toggles only selected splats bounding rings.
Splat rendering can be disabled, shows only center points so scene is viewable as a point cloud. N toggles splat rendering
Rings view mode uses bounding rings slider for rings size but maybe that mode could be removed as setting center points alpha to zero and enabling bounding rings gives the same view essentially.