Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor view options #104

Closed
wants to merge 19 commits into from
Closed

Conversation

7Jaws9Eyes
Copy link

@7Jaws9Eyes 7Jaws9Eyes commented Jun 6, 2024

Added a bunch of configurable viewing options to the side bar, including keyboard shortcuts for toggles.
Could be useful to make selecting splats more precise, especially if more editing tools are added in the future.

Sidebar with new options:
image

Center point colors and alpha value can be changed. Same for selected center points.
Keyboard shortcut J toggles center point alpha.
Keyboard shortcut L toggles alpha of selected center points.
(image below shows 2 custom colors and alpha values for center points)
image

Color of splats in selection can be interpolated with custom color. (interpolation 0 leaves color of selected splats unchanged).
K toggles selected splat coloration.
image

Bounding rings of splats can be enabled in the centers view mode -> centers and bounds in same view. Can also be only enabled for selected splats.
Keyboard shortcut O toggles bounding rings. Q toggles only selected splats bounding rings.
image

Splat rendering can be disabled, shows only center points so scene is viewable as a point cloud. N toggles splat rendering
image

Rings view mode uses bounding rings slider for rings size but maybe that mode could be removed as setting center points alpha to zero and enabling bounding rings gives the same view essentially.

@willeastcott
Copy link
Contributor

I think these settings belong in the OPTIONS section of the UI panel. Can you move them there and update the screenshot in the PR description please?

@7Jaws9Eyes
Copy link
Author

done.
do you think keeping "mode" option in camera section is still useful? as you can just enable the rings in the options now anyway.
and should "splat size" be moved to options section too?

@willeastcott
Copy link
Contributor

I think Mode belongs in the SELECTION section actually. The UI does need a bit of a redesign, I think. I'm meeting someone about it today. 😄

Sorry about the changes we've made since you submitted your PR - there are a couple of files with conflicts to resolve.

@7Jaws9Eyes
Copy link
Author

no problem, ill adapt it further when you request it.
should i merge my branch with your main branch on my fork and push it to this PR or would you prefer to do it?

@willeastcott
Copy link
Contributor

If you could merge from the main branch into your fork, that'd be great!

# Conflicts:
#	src/editor.ts
#	src/ui/control-panel.ts
@7Jaws9Eyes
Copy link
Author

done :)

@willeastcott willeastcott added the enhancement New feature label Jun 11, 2024
src/splat-debug.ts Outdated Show resolved Hide resolved
src/splat-debug.ts Outdated Show resolved Hide resolved
src/splat.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
src/main.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@willeastcott willeastcott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making all the requested changes, @7Jaws9Eyes. So consider my review a first pass - we still need feedback and a review from @slimbuck. He's out this week but will be back on Monday.

boundary rings will keep color even if splat highlighting is toggled off
accidentally introduced this bug when cleaning up keyboard shortcuts
@slimbuck
Copy link
Member

This was eventually done in #258

@slimbuck slimbuck closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants