Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add french support #195

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Add french support #195

merged 1 commit into from
Sep 27, 2024

Conversation

AlexMorgand
Copy link
Contributor

Have to test it properly and reread just to be sure :)

@willeastcott
Copy link
Contributor

This is great - thanks!

I did just merge some more localizations: #196

Would you be able to add these extra translations to your PR please?

@willeastcott
Copy link
Contributor

And it seems my PR caused a merge conflict in your PR but it's super-easy to resolve. 😄

@willeastcott
Copy link
Contributor

One more request. Can you move the fr block to be after en and before ja please?

@AlexMorgand
Copy link
Contributor Author

Sure let me amend those

@AlexMorgand
Copy link
Contributor Author

Done. Testing locally.

@willeastcott willeastcott merged commit 8ff8e24 into playcanvas:main Sep 27, 2024
2 checks passed
@willeastcott willeastcott self-assigned this Sep 27, 2024
@willeastcott willeastcott added the enhancement New feature label Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants