Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stream during save #222

Merged
merged 13 commits into from
Oct 22, 2024
Merged

Stream during save #222

merged 13 commits into from
Oct 22, 2024

Conversation

slimbuck
Copy link
Member

This PR:

  • implements streaming output for PLY so we don't allocate unnecessary memory blocks
  • fixes a bug with saving which resulted in large scenes running out of memory on save
  • reimplements the spinner to capture input because streamed output results in input working during save
  • fix small picker bug introduced in Add selection outline #221

@slimbuck slimbuck added the bug Something isn't working label Oct 22, 2024
@slimbuck slimbuck requested a review from a team October 22, 2024 11:09
@slimbuck slimbuck self-assigned this Oct 22, 2024
@slimbuck slimbuck merged commit fc7b998 into playcanvas:main Oct 22, 2024
2 checks passed
@slimbuck slimbuck deleted the stream-dev branch October 22, 2024 11:50
This was referenced Oct 22, 2024
Merged
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvaligursky mvaligursky mvaligursky approved these changes

@willeastcott willeastcott willeastcott approved these changes

Assignees

@slimbuck slimbuck

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@slimbuck @willeastcott @mvaligursky