Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple Lasso-Selection #269

Merged
merged 3 commits into from
Nov 8, 2024
Merged

Conversation

simonbethke
Copy link
Contributor

@simonbethke simonbethke commented Nov 7, 2024

This is the lasso-selection without reorganizing the code of the selection-tools

lasso-selection.mp4

@simonbethke simonbethke changed the title SImple Lasso-Selection Simple Lasso-Selection Nov 7, 2024
@simonbethke
Copy link
Contributor Author

When marching ants have been completed, #266 has to get merged into this

@slimbuck slimbuck self-assigned this Nov 8, 2024
@slimbuck slimbuck added the enhancement New feature label Nov 8, 2024
Remove unnecessary showing mask, use polygon instead of polyline.
Copy link
Member

@slimbuck slimbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks so much for this!

@slimbuck slimbuck merged commit b13009c into playcanvas:main Nov 8, 2024
2 checks passed
@simonbethke
Copy link
Contributor Author

Hmm, I just had fixed your comments and started fighting git. Later I realized that I was fighting the changes that you requested me to do and then did yourself.

@slimbuck
Copy link
Member

slimbuck commented Nov 8, 2024

Oh sorry, yeah realised it'd be quicker.

@slimbuck slimbuck mentioned this pull request Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants