-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Control Camera Speed #285
Control Camera Speed #285
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great, thanks so much! Left a few comments - please call the variable camera flySpeed.
I have made those changes. However, I wish I could make the slider-control transparent for key-up/down events. Any idea how to accomplish that? |
Might be possible, but quite fiddly. How about hooking + and - keys to speed camera up and down? |
I am not sure about this. In general, shortcut keys start overlapping. Think about "p" for picker or poly. And I would like to implement an enable / disable wasd-navigation switch |
I've merged the changes from yesterday's lint update into your branch. |
I also added the missing localisations. Please check you're happy before I merge. |
I mean, nothing is currently using + and - right now, but anyway these are bigger changes we can do at a later time. |
I think you changed every single line of code :) |
I added a simple slider that allows to control the camera speed. Currently it is by default set to 5m/s and it can be set between 0.1 and 30 m/s.
However, I found a bug that happens when moving forward through the scene origin. By doing that, the camera turns around and looks back to the origin. Up and Down arrows now switched directions. #286