fix: persist CIDv1 multicodec #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change avoids creating new CID object if it is already v1 and persists non-dag-pb multicodec if v1 is passed in text form as specified in https://github.com/libp2p/specs/blob/master/RFC/0001-text-peerid-cid.md License: MIT Signed-off-by: Marcin Rataj <[email protected]>
pldespaigne
approved these changes
Nov 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change avoids creating new CID object if it is already v1 and persists non-dag-pb multicodec if v1 is passed in text form as specified in https://github.com/libp2p/specs/blob/master/RFC/0001-text-peerid-cid.md
In also added tests that ensure multicodec of v1 is persisted.
CID internals can be inspected with https://cid.ipfs.io
cc https://github.com/ipfs/ipfs/issues/337, libp2p/specs#209, libp2p/specs#216, MetaMask/metamask-extension#7362