Refactor site creation in Products.CMFPlone to use plone.distribution

[ericof]

Part of #3854

Tasks

• Products.CMFPlone.browser.admin.AddPloneSite only registered if plone.distribution is not available
• Refactor site creation to be like the function from plone.distribution (supporting a distribution)
• Remove creation of example content (make sure those are still created in the test layer)

[mauritsvanrees]

Without plone.distribution available, do we want to remove the Advanced options? I can imagine that we want to point users to either distributions or just let them install the extra profiles via the Add-ons control panel.

Actually, you can't install "Zope Root Cookie Login" (Products.PlonePAS:root-cookie profile) in the control panel. You would need to do that via portal_setup. But that is really an advanced corner case. Since it works on the Zope root, you don't even want it available for install from within Plone. So I think that is fine. Anyway, you can still do that in a Distribution. :-)

[mauritsvanrees]

Progress during Buschenschankensprint (in the train back actually)

• Refactor site creation #3981
• PloneFixture: explicitly install plone.app.contenttypes:default. plone.app.testing#97

[mauritsvanrees]

The CMFPlone PR does not "Refactor site creation to be like the function from plone.distribution (supporting a distribution)". I don't really know what that would like like if plone.distribution is not available, which is the only way that the plone-addsite view is even visible.

Ah, or do you mean that the factory.addPloneSite function should be able to install a distribution if plone.distribution is available? Then this function would accept an extra distribution keyword argument, and call a function in plone.distribution. Something like that?