Refactor site creation #3981
Merged
Refactor site creation #3981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ribution` is not available.
If you need more options, you should add a Plone Distribution to your packages. The main ones are `plone.volto` and `plone.classicui`. We now only create a basic Plone site without default example content.
This was already disabled in 2018. Instead, probably since the same time, we show the plone-overview page on the Zope site root, by using our AppTraverser.
…le_id` keyword arguments. Show a deprecation warning when these are used. We never setup content anymore. Use a Plone Distribution if you need this. Or pass an extra profile id in the `extension_ids` keyword argument. Our fallback Add Plone Site form (shown if `plone.distribution` is not available), now passes the following extension ids: 1. the `factory._TYPES_PROFILE`: `plone.app.contenttypes:default` 2. `plone.app.caching:default` if the package is available. 3. `plonetheme.barceloneta:default`
Currently, lots of tests fail. To fix that, we need to add the contenttypes profile
in `plone.app.testing.layers.PloneFixture`:
```
# Extension profiles to be installed with site setup
extensionProfiles = (
"plone.app.contenttypes:default",
"plonetheme.barceloneta:default",
)
```
Or we change our factory to have those two as default extension_ids, and remove that part from the plone-addsite view.
This comment was marked as resolved.
This comment was marked as resolved.
This was referenced Jun 19, 2024
stevepiercy
requested changes
Jun 20, 2024
Co-authored-by: Steve Piercy <[email protected]>
Suggestion by @stevepiercy.
stevepiercy
approved these changes
Jun 27, 2024
2 tasks
We then pass all other arguments and keyword arguments to the `plone.distribution` site api.
mauritsvanrees
force-pushed
the
distributions
branch
from
a442672
to
bea0b3d
Compare
One of the `test_factory.py` tests now uses a new layer using the new `PRODUCTS_CMFPLONE_DISTRIBUTIONS_FIXTURE`. This is the only layer that defines a dummy distribution in `tests/configure-distributions.zcml`. Somehow, with the `plone.distribution` zcml loaded, a few tests throw an error when visiting `@@search`: `zExceptions.NotFound: plone.restapi.controlpanels.registry.SearchControlpanel object at 0x116ea02f0`
|
Upon merge and release, we need to update the documentation. See plone/documentation#1721 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of #3961
This affects the site creation process when
plone.distributionis not available. See the individual commits for details. In this case, the plone-overview page on the Zope root looks like this:The Advanced version of the Add Plone Site form is gone. For advanced options you should use a Plone Distribution.
This needs a change in
plone.app.testing, otherwise loads of tests fail. Only a one line change though. I will link the PR.I will keep this as Draft PR for now.