Added start and end filters in redirectionSet.

[Faakhir30]

Refers plone/plone.restapi#1792

Currently, RedirectionSet only supports created date, which is filtering by date_created >= created

I've added start and end param support, to filter by start or end param.
We can use either or both or None of these parameters.

Also, I've removed the created param, as its functionality is being covered by the start param.

I'll also update in plone.restapi and to volto once status of this PR is confirmed. Thanks.

[mister-roboto]

@Faakhir30 thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

[stevepiercy]

@Faakhir30 you need to tell Jenkins to run the test suite for this repo. See comment above, and our shiny new CI docs about Jenkins: https://6.docs.plone.org/contributing/core/continuous-integration.html#jenkins

[Faakhir30]

@jenkins-plone-org please run jobs

[Faakhir30]

I see jenkins failed to clone my forked repo

This is because jenkins is assuming that I've forked with same repo name Products.CMFPlone, where as I cloned by name Products.CMFPlone-repo :)

Will create an enhancement issue for this, and change my fork name to solve for now.

[Faakhir30]

@jenkins-plone-org please run jobs

[stevepiercy]

@Faakhir30 you were close with your analysis. I realize that Jenkins does not recognize external forks, and expects a pull request to come from a branch from this repo, not a fork. However as a member of the Plone Contributors Team, you lack permission to write to this repo and cannot create a branch.

Because you've contributed to three other repositories under the GitHub Plone organization, and you have so far followed our contributing guidelines exceptionally well, especially for a new contributor to Plone, I decided to invite you to the Plone Developers Team, which has write access to this and all other repos under the GitHub Plone organization. Would you please accept the invitation, then create a new pull request from a new branch that you create in this repository and close this PR? You will probably need to change your upstream branch git configuration accordingly.

For the @plone/ci-team, now that we have the Contributors Team who lack access to write to Plone repositories, is it possible to configure Jenkins to clone external forks? In days of yore, everyone who signed the Plone Contributor Agreement was assigned to the Developers Team, but we realized within the last two years that it was a Very Bad Idea™ to allow write access to repos and potentially allow evil code execution, thus we created the Contributors Team.

[Faakhir30]

Thanks for adding to the core developers. The pleasure is all mine.

And Yeah, I'm aware of changes due to last year's action, read some conversations In community.plone.org by Fred van Dijk.

Will create PR in this repo as you described soon.

[Faakhir30]

@stevepiercy I've seen Jenkins logs in detail now, IMO, it is recognizing external clones, it's just a fork-name issue as I mentioned, I've tested by editing my fork name==upstream name, and Jenkins ran successfully, however, the test case failed is due to my code, and I'll see it back within 1-2 days.
So, I assume it's not necessary to create PR from the same repo.

[Faakhir30]

@jenkins-plone-org please run jobs

[Faakhir30]

@jenkins-plone-org please run jobs

[Faakhir30]

@jenkins-plone-org please run jobs