-
-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix robottests for latest contentbrowser updates #4018
Conversation
@petschki thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment:
To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks! Sidenote: If i run bin/test -s Products.CMFPlone -t test_contentbrowser.robot --all
all is fine, but if i run ROBOT_BROWSER=chrome bin/test -s Products.CMFPlone -t test_contentbrowser.robot --all
then some tests fails. I think it is a viewport misconfiguration, and has nothing todo with the tests.
OK, on my Mac both commands run without failures. |
That was the reason why I recently changed the the tests with the JS Hack in the tests. But this happens only on my small Notebook at Home. On my PC at work with a larger Screen all tests run without problems. I think it's a Selenium thing. I hope that all the Problems go away with port of tests to playwright. But this takes a while. The CI is sometimes broken, depending on which node the tests are running. that's my impression. |
There was a version update recently on coredev which looks like it made the tests flaky. I've created a PR which reverts this. |
this is outdated ... I'll update to playwright asap |
see plone/plone.staticresources#354