Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add playwright based robotframework tests #868

Merged
merged 3 commits into from
Jul 9, 2023
Merged

Conversation

gforcada
Copy link
Member

@gforcada gforcada commented Jun 29, 2023

Big disclaimer: all credit goes to @datakurre , I'm merely creating the PRs and doing the integration of the code 😅

Part of plone/Products.CMFPlone#3813

@gforcada gforcada changed the title Datakurre rfbrowser Add playwright based robotframework tests Jun 29, 2023
@gforcada
Copy link
Member Author

@jenkins-plone-org please run jobs

tests.cfg Outdated
@@ -33,6 +33,7 @@ test-eggs =
plone.app.redirector
plone.app.registry
plone.app.relationfield
plone.app.robotframework [test]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@datakurre I've been banging my head against the wall on this... but might it be that the robot tests on plone.app.robotframework are already broken? For example on p.a.rf/tests/test_autologin_library.robot the keyword I open a personal menu tries to get #portal-personaltools > a (source) and that is nowhere to be found (tested it debugging it, but also on demo.plone.org)

If we do not run the tests for plone.app.robotframework, but keep its changes, then we can test for example my port on plone.app.discussion and use that for testing the GHA and Jenkins integration of playwright, which I have sort of working, but need to have stable tests to run them with 😄

@gforcada gforcada marked this pull request as ready for review July 6, 2023 21:18
@gforcada
Copy link
Member Author

gforcada commented Jul 6, 2023

@jenkins-plone-org please run jobs

@gforcada
Copy link
Member Author

gforcada commented Jul 6, 2023

@jenkins-plone-org please run jobs

@gforcada gforcada merged commit 3b5c2b6 into 6.0 Jul 9, 2023
@gforcada gforcada deleted the datakurre-rfbrowser branch July 9, 2023 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants