Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional tests #51

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Functional tests #51

wants to merge 10 commits into from

Conversation

sneridagh
Copy link
Member

No description provided.

@sneridagh sneridagh requested a review from ericof as a code owner July 8, 2024 11:16
@sneridagh
Copy link
Member Author

@ericof I polished the generator until I reached what I've found this morning:

https://github.com/plone/cookieplone-templates/actions/runs/9840829807/job/27165988173#step:15:15

If you run make check inside the backend folder, tox gets crazy and do not find the project.pytoml file.

Also in the backend, there's no make format, the check command is make check while in the frontend is make lint.

I kind of dislike that check also does format, because it leads to tons of confusion.

@stevepiercy
Copy link
Contributor

I recall that we abolished make check because it means "check code", not "reformat and write code". Let's burn it with 🔥. make lint or make format both make sense, depending on what the command actually does.

@sneridagh
Copy link
Member Author

I'm +1000 with @stevepiercy on this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants