-
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add plonecli/bobtemplates.plone compatible markers and configuration #63
base: main
Are you sure you want to change the base?
Changes from 15 commits
acb3f34
fb7dff8
986a553
4ae52d3
b6703f7
3dd2b11
f0a1b9c
1a38961
dd2cbb9
6b7d2b0
02af5e4
21eebf9
2000af5
2e71c63
ff5ae21
9976d3b
0388397
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
[variables] | ||
package.dottedname = {{ cookiecutter.python_package_name }} | ||
package.browserlayer = IBrowserLayer | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
[main] | ||
version = 6.0.13 | ||
template = plone_addon | ||
git_init = True | ||
python = python3 | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is not necessarily a blocker, but would it be possible to add support for mr.bob/bobtemplates.plone to get their settings from pyproject.toml, so that we don't need more config files? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I guess that there's no problem with that. Would you mind adding an issue in bobtemplates.plone repo? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,4 +5,6 @@ | |
i18n_domain="{{ cookiecutter.python_package_name }}" | ||
> | ||
|
||
<!-- -*- extra stuff goes here -*- --> | ||
|
||
</configure> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -2,4 +2,6 @@ | |
|
||
<!-- Indexers/Metadata --> | ||
|
||
<!-- -*- extra stuff goes here -*- --> | ||
|
||
</configure> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
<configure | ||
xmlns="http://namespaces.zope.org/zope" | ||
xmlns:genericsetup="http://namespaces.zope.org/genericsetup" | ||
i18n_domain="{{ cookiecutter.python_package_name }}" | ||
> | ||
|
||
<!-- -*- extra stuff goes here -*- --> | ||
|
||
</configure> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,6 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<object name="portal_controlpanel"> | ||
|
||
<!-- -*- extra stuff goes here -*- --> | ||
|
||
</object> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
<?xml version="1.0"?> | ||
<registry | ||
xmlns:i18n="http://xml.zope.org/namespaces/i18n" | ||
i18n:domain="{{ cookiecutter.python_package_name }}"> | ||
|
||
<!-- -*- extra stuff goes here -*- --> | ||
|
||
</registry> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<rolemap> | ||
<permissions> | ||
|
||
<!-- -*- extra stuff goes here -*- --> | ||
</permissions> | ||
</rolemap> |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,4 +16,6 @@ | |
</genericsetup:upgradeSteps> | ||
--> | ||
|
||
<!-- -*- extra stuff goes here -*- --> | ||
|
||
</configure> |
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,5 @@ | ||
<configure xmlns="http://namespaces.zope.org/zope"> | ||
|
||
<!-- -*- extra stuff goes here -*- --> | ||
|
||
</configure> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to update the version number here. The current version of
bobtemplates.plone
is 6.3.3. Is this feature already in a release or a future one?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No yet, there's a pending PR on bobtemplates.plone to be able to use these changes.